-
Notifications
You must be signed in to change notification settings - Fork 178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Enhancement]: Add 'app_type' column for AppDB model with updated API responses #1994
base: main
Are you sure you want to change the base?
Conversation
…pe' to AppDB model
…pe enum with RAG, and update App API response
- Create DB function to get 'app_type' from template - Update DB function 'create_app_and_envs' to include 'app_type'
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
…_app_type_from_template_by_id'
…s for app categorization
…atest migration head - Refactored the migration check to compare the current database migration head against the latest migration script head. - Enhanced `get_current_migration_head_from_db` to ensure only one migration head is tracked. - Updated logic in `get_pending_migration_head` to reduce unnecessary checks and handle first-time setup more efficiently. - Improved error handling and clarified logging messages for better debugging.
Failing CLI Command Tests / Serve-to-OSS:The failing test is due to a missing schema migration in OSS production. CLI Commands Working Locally:Next Steps:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes to the tags lgtm! Thanks @aybruhm
...ackend/migrations/postgres/versions/1abfef8ed0ef_added_the_app_type_column_to_the_app_db_.py
Outdated
Show resolved
Hide resolved
…lumn to the app_db table
Description
This PR introduces a new
app_type
column in theAppDB
model and updates the corresponding API responses. The changes include defining anAppType
enum, specifying the enum type for theapp_type
column, and updating the backend to properly handle and return the new app type in API responses. Additionally, a schema migration script has been generated and applied using Alembic.Related Issue
Closes AGE-540
Sibling PRs
Changes Included:
AppType
enum and extended support for other app types.AppDB
model to include theapp_type
column.create_app_and_envs
andapp_type_from_template
functions to support the new enum.app_type
column.What to QA
app_type
.app_type
is correctly reflected (should be set to 'custom').app_type
column has been added with the correct enum type.Acceptance Tests
app_type
is correctly reflected in the playground.app_type
is correctly set to 'custom' and the app works as expected.app_type
column is added to theapp_db
table and mapped correctly with the enum type.